Support dynamically detecting changes when .gitignore is updated #6962

sat0yu · 2018-09-11T23:25:22Z

Summary

jest (watchman) could not detect any changes in hidden files (e.g. .gitignore )
Support dynamically detecting changes when .gitignore is updated #5730
this PR enables jest to do so for specified hidden files

Test plan

followed this scenario #5730 (comment)

Sure, here's an example: https://github.com/nevir/jest-sourcemap-gitignore

Steps to repro:

Run tsc --watch (and keep it running)

Run jest --watch

Edit foo.test.ts, and observe that jest notices the file change, but doesn't run any tests

Remove *.js from .gitignore

Edit foo.test.ts again, and observe that jest runs the test

(I don't think this is a bug; pretty sure it's a feature request)

codecov-io · 2018-09-12T03:18:10Z

Codecov Report

Merging #6962 into master will decrease coverage by 1.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6962      +/-   ##
==========================================
- Coverage   67.99%   66.89%   -1.11%     
==========================================
  Files         248      250       +2     
  Lines        9490    10437     +947     
  Branches        6        4       -2     
==========================================
+ Hits         6453     6982     +529     
- Misses       3035     3454     +419     
+ Partials        2        1       -1

Impacted Files	Coverage Δ
packages/jest-haste-map/src/index.js	`87.5% <100%> (-6.07%)`	⬇️
packages/jest-cli/src/testResultHelpers.js	`9.37% <0%> (-63.36%)`	⬇️
packages/jest-validate/src/errors.js	`54.54% <0%> (-45.46%)`	⬇️
packages/jest-validate/src/warnings.js	`54.54% <0%> (-45.46%)`	⬇️
packages/jest-runtime/src/helpers.js	`50% <0%> (-40.48%)`	⬇️
packages/jest-cli/src/TestScheduler.js	`44.27% <0%> (-28.46%)`	⬇️
packages/jest-runner/src/index.js	`47.82% <0%> (-27.79%)`	⬇️
packages/jest-each/src/index.js	`77.77% <0%> (-22.23%)`	⬇️
packages/jest-config/src/Deprecated.js	`45.45% <0%> (-21.22%)`	⬇️
packages/jest-docblock/src/index.js	`80% <0%> (-20%)`	⬇️
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103f068...d0f3661. Read the comment docs.

CHANGELOG.md

docs/Configuration.md

SimenB · 2018-09-12T11:37:57Z

@sat0yu I still think I'd prefer just support the ignore files of the 2 VCS-es we support. See https://fishshell.com/docs/current/design.html (Configurability is the root of all evil). I can't really think of any cases where this config would be needed for other use cases?

thymikee · 2018-09-22T10:45:33Z

Yep, I'm with @SimenB on that. We support 2 VCS so we can "hardcode" their ignore files so it's transparent to the user.

sat0yu · 2018-09-22T11:19:51Z

@thymikee how about this change? 235344b

thymikee

LGTM. Wonder if that affects performance anyhow. Also a test would be great to add. And a changleog :)

thymikee · 2018-12-19T07:55:49Z

@sat0yu mind resolving conflicts?
@SimenB have more thoughts on this change?

SimenB · 2018-12-19T08:45:04Z

Would love to see a test, but the code lgtm :)

SimenB · 2018-12-19T08:45:38Z

@rickhanlonii, since you use this in RN

SimenB · 2018-12-24T12:40:39Z

@sat0yu could you update the changelog and resolve the conflict?

rickhanlonii · 2018-12-24T15:25:53Z

packages/jest-haste-map/src/index.js

    let changeQueue = Promise.resolve();
    let eventsQueue = [];
    // We only need to copy the entire haste map once on every "frame".
    let mustCopy = true;

    const createWatcher = root => {
      const watcher = new Watcher(root, {
-        dot: false,
-        glob: extensions.map(extension => '**/*.' + extension),
+        dot: true,


Would this impact all dotfiles not just .gitignore and .hgignore?

I don't think so because the line !suffixes.some(suffix => filePath.endsWith(suffix)) filters other dotfiles

…ly-detection-for-gitignore

sat0yu · 2019-01-04T11:01:27Z

@SimenB @thymikee @rickhanlonii thanks for your comments and sorry for the late response.

This PR still has a few failures in the following 2 Test Suites.
And I have not been able to fix them yet.
Could you give me some advice to resolve them?

packages/jest-haste-map/src/__tests __/index.test.js
- could not include .gitignore (and .hgignore) in cases using sane
packages/jest-cli/src/__tests __/SearchSource.test.js
- exclude all dot directories (e.g. .hiddenFolder) against my expectation

SimenB · 2020-07-31T07:14:42Z

@sat0yu hey, sorry about not responding for a year and a half 😬 I got a notification for this PR for some reason just now.

Jest 26.2 includes #10075 which adds support for dotfiles (aka hidden files). So I think this can be closed now?

github-actions · 2021-05-11T04:07:21Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Sep 11, 2018

sat0yu changed the title ~~Support dynamically detection for gitignore~~ Support dynamically detecting changes when .gitignore is updated Sep 11, 2018

sat0yu force-pushed the support-dynamically-detection-for-gitignore branch from d6b6e5f to 5779d91 Compare September 11, 2018 23:42

sat0yu mentioned this pull request Sep 11, 2018

Support dynamically detecting changes when .gitignore is updated #5730

Closed

sat0yu force-pushed the support-dynamically-detection-for-gitignore branch from 9b7f562 to 6242aaa Compare September 12, 2018 02:58

Mikeweld19 approved these changes Sep 12, 2018

View reviewed changes

SimenB reviewed Sep 12, 2018

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs/Configuration.md Outdated Show resolved Hide resolved

SimenB requested a review from thymikee September 17, 2018 12:22

sat0yu added 2 commits September 22, 2018 16:57

enable dynamically detection for .gitignore/.hgignore

9bb5705

tweak; use spreading assignment

a9054a5

sat0yu force-pushed the support-dynamically-detection-for-gitignore branch from 8790d0b to a9054a5 Compare September 22, 2018 08:00

revise internal option type definition

9392cef

SimenB requested review from rickhanlonii, mjesun and rubennorte September 22, 2018 09:06

exclude hidden files from internal option

235344b

thymikee reviewed Sep 22, 2018

View reviewed changes

SimenB approved these changes Dec 19, 2018

View reviewed changes

rickhanlonii reviewed Dec 24, 2018

View reviewed changes

sat0yu added 3 commits January 4, 2019 17:51

Merge remote-tracking branch 'upstream/master' into support-dynamical…

ec1ae25

…ly-detection-for-gitignore

update changelog

11f5a25

(wip) modified tests

d0f3661

sat0yu closed this Aug 2, 2020

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support dynamically detecting changes when .gitignore is updated #6962

Support dynamically detecting changes when .gitignore is updated #6962

sat0yu commented Sep 11, 2018 •

edited

Loading

codecov-io commented Sep 12, 2018 •

edited

Loading

SimenB commented Sep 12, 2018

thymikee commented Sep 22, 2018

sat0yu commented Sep 22, 2018

thymikee left a comment

thymikee commented Dec 19, 2018

SimenB commented Dec 19, 2018

SimenB commented Dec 19, 2018 •

edited

Loading

SimenB commented Dec 24, 2018

rickhanlonii Dec 24, 2018

sat0yu Jan 4, 2019

sat0yu commented Jan 4, 2019 •

edited

Loading

SimenB commented Jul 31, 2020

github-actions bot commented May 11, 2021

Support dynamically detecting changes when .gitignore is updated #6962

Support dynamically detecting changes when .gitignore is updated #6962

Conversation

sat0yu commented Sep 11, 2018 • edited Loading

Summary

Test plan

codecov-io commented Sep 12, 2018 • edited Loading

Codecov Report

SimenB commented Sep 12, 2018

thymikee commented Sep 22, 2018

sat0yu commented Sep 22, 2018

thymikee left a comment

Choose a reason for hiding this comment

thymikee commented Dec 19, 2018

SimenB commented Dec 19, 2018

SimenB commented Dec 19, 2018 • edited Loading

SimenB commented Dec 24, 2018

rickhanlonii Dec 24, 2018

Choose a reason for hiding this comment

sat0yu Jan 4, 2019

Choose a reason for hiding this comment

sat0yu commented Jan 4, 2019 • edited Loading

SimenB commented Jul 31, 2020

github-actions bot commented May 11, 2021

sat0yu commented Sep 11, 2018 •

edited

Loading

codecov-io commented Sep 12, 2018 •

edited

Loading

SimenB commented Dec 19, 2018 •

edited

Loading

sat0yu commented Jan 4, 2019 •

edited

Loading